imbajin commented on code in PR #884:
URL:
https://github.com/apache/hugegraph-toolchain/pull/884#discussion_r4431037319
##########
hugegraph-hubble/hubble-fe/src/pages/Operations/SourceDiagnostics.js:
##########
@@ -201,14 +241,17 @@ const SourceDiagnostics = ({sources = {}, sourceName,
nodes = [], focus = false,
{!recovered && <RecoverySteps unmappedPd={unmappedPd}
largeResponse={largeResponse}
raftTooLarge={raftTooLarge} />}
{source.diagnostics !== requestDetails &&
<DiagnosticRequest diagnostics={source.diagnostics} />}
+ {type === 'PD' && <PdEndpointMetrics
sample={source.diagnostics?.pd_endpoint_metrics}
+ sourceStale={source.stale} />}
Review Comment:
[P2] Propagate failed-refresh staleness to the endpoint sample
This corroborates the existing org review:
https://github.com/hugegraph/hugegraph-toolchain/pull/127#discussion_r4430972111
.
On the PD node detail page, a successful response can contain a
PARTIAL/unmapped PD source with an AVAILABLE, fresh endpoint sample. If the
next refresh fails, NodeDetail marks only the retained snapshot and node as
stale, then passes the unchanged `data.sources` here. `PdEndpointMetrics`
checks `source.stale` and the nested sample flags, not the snapshot flag, so
the old CPU/memory sample remains displayed as available despite the failed
refresh.
Please propagate retained-snapshot staleness into sources (or explicitly
into this panel) and keep it through an in-flight retry until a successful
response arrives. Add a node-detail regression that loads an unmatched PD
sample, rejects refresh, and verifies its values are no longer presented as
current.
Independent verification: exact-head static tracing and a bounded probe of
the extracted retained-snapshot updater and freshness predicate. This was not a
React/browser/network execution.
Version sources:
https://github.com/apache/hugegraph-toolchain/blob/ad3f0d6b7c79be119cbac5fc062f813c38740981/hugegraph-hubble/hubble-fe/src/pages/Operations/NodeDetail.js#L463-L474
and
https://github.com/apache/hugegraph-toolchain/blob/ad3f0d6b7c79be119cbac5fc062f813c38740981/hugegraph-hubble/hubble-fe/src/pages/Operations/SourceDiagnostics.js#L101-L140
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
