bitflicker64 commented on code in PR #884:
URL:
https://github.com/apache/hugegraph-toolchain/pull/884#discussion_r4431440361
##########
hugegraph-hubble/hubble-fe/src/pages/Operations/SourceDiagnostics.js:
##########
@@ -100,6 +101,45 @@ const PdMetricMapping = ({mapping, nodes}) => {
);
};
+// These are one configured endpoint's response, not a discovered PD node
+// and not an aggregation: a Service may route consecutive scrapes elsewhere.
+const PdEndpointMetrics = ({sample, sourceStale}) => {
+ const {t, i18n} = useTranslation();
+ if (!sample) return null;
+ const status = sample.metric_status ?? {};
+ const fresh = !sourceStale && !status.stale && status.fresh === true
Review Comment:
Important: when a refresh fails, `Nodes.js` keeps the previous
`data.sources` unchanged, so the PD endpoint sample on
`/operations/nodes?type=PD&source=pd` still shows old values as `Available`.
Mark retained `sources` stale in that catch path, as `NodeDetail` does, and
cover it with a rejected-refresh test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
