bitflicker64 commented on PR #557:
URL: https://github.com/apache/hugegraph-doc/pull/557#issuecomment-6556233018

   ## Review summary: R1 (FULL)
   
   **Reviewed:** head `7db47aaa` against base `7d1737b5`, all 49 files.
   
   **Verdict:** not ready to merge yet. Two problems break existing routes: 
historical SDK navigation is lost, and the old CN client URLs return 404. One 
page also gives inaccurate Cypher information.
   
   **Score: 4.3 / 10.** This is the mean of 2 of 4 reviewers so far, so it is 
provisional.
   
   | Reviewer | Raw | Adjusted | Deductions |
   |---|---|---|---|
   | Reviewer A (model not reported) | 5.0 | 5.0 | 2 Important, 2 Minor |
   | Reviewer B (Claude Opus 5.5) | 3.5 | 3.5 | 2 Important, 5 Minor |
   | Reviewer C | pending | | |
   | Reviewer D | pending | | |
   
   **Important:**
   - Historical SDK navigation is lost for 1.0 to 1.7, as already reported in 
[this 
review](https://github.com/apache/hugegraph-doc/pull/557#pullrequestreview-5727395484).
 Reviewer A reached the same conclusion independently.
   - [The CN aliases get a double `/cn` prefix, so the old CN client URLs 
return 
404](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090937). 
This is the cause of the `cn/index.html` failure in CI.
   - [Switching from the old Java quickstart to latest falls back to the docs 
home 
page](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090953).
   - [The "Unsupported Features" list includes `OPTIONAL MATCH`, `WITH` and 
`UNWIND`](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090956).
 Reviewers rated this Important or Minor.
   
   **Minor:** [EN section numbering and old 
anchors](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090958),
 [wrong sample-dataset 
description](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090961),
 [Cypher error and Content-Type 
wording](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090965),
 [removed "since 1.8.0" 
caveats](https://github.com/apache/hugegraph-doc/pull/557#discussion_r4435090968).
   
   **Checks:** `dist/validate-links.sh` and the scripts unit tests pass. A 
strict Hugo 0.168.0 build succeeds but generates the CN redirects under 
`/cn/cn/`. No browser check of the version switcher was done.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to