bitflicker64 commented on code in PR #557: URL: https://github.com/apache/hugegraph-doc/pull/557#discussion_r4436879465
########## content/en/docs/quickstart/toolchain/hugegraph-loader.md: ########## @@ -190,11 +191,14 @@ For Oracle input, obtain a JDBC driver JAR compatible with your Oracle/JDK versi The startup script loads JARs there; installing a driver only in the local Maven repository does not put it on Loader’s runtime classpath. ### 3 How to use -To import a dataset, prepare the schema, data and mapping, then run Loader. -- Write graph schema -- Prepare data files -- Write input source map files -- Execute command import + +Importing a dataset into HugeGraph follows four ordered steps: + +1. [Construct the graph schema](#31-construct-graph-schema) — Define property keys, vertex labels, and edge labels in Groovy. +1. [Prepare data files](#32-prepare-data) — Format data records (TEXT, CSV, JSON, HDFS, or DB tables). +1. [Write input source mapping file](#33-write-data-source-mapping-file) — Create the JSON mapping specification. +1. [Execute data import](#34-execute-the-import) — Run `hugegraph-loader.sh` to load data into the graph. Review Comment: Minor: `#34-execute-the-import` matches no heading; section 3.4 renders as `#34-execute-command-import`, so this step link goes nowhere. Point it at `#34-execute-command-import`, and the CN step at `#34-执行命令导入` instead of `#34-执行导入`. ########## content/en/docs/guides/architectural/custom-plugin.md: ########## @@ -26,13 +28,12 @@ Currently, the plug-in method provides extensions in the following dimensions: ### Plug-in implementation mechanism -1. HugeGraph provides a plug-in interface HugeGraphPlugin, which supports plug-in through the Java SPI mechanism -2. HugeGraph provides four extension registration functions as static methods on HugeGraphPlugin: registerOptions(), registerBackend(), registerSerializer(), registerAnalyzer() -3. The plug-in implementer implements the corresponding Options, Backend, Serializer or Analyzer interface -4. The plug-in implementer implements register()the method of the HugeGraphPlugin interface, registers the specific -implementation class listed in the above point 3 in this method, and packs it into a jar package -5. The plug-in user puts the jar package in the HugeGraph Server installation directory plugins, modifies the relevant -configuration items to the plug-in custom value, and restarts to take effect +1. **Provide SPI interface**: HugeGraph provides the `HugeGraphPlugin` interface, supporting pluggability via Java SPI. +2. **Registration functions**: `HugeGraphPlugin` exposes static registration methods: `registerOptions()`, `registerBackend()`, `registerSerializer()`, and `registerAnalyzer()`. +3. **Implement components**: The developer implements the corresponding `OptionSpace`, `BackendStoreProvider`, `AbstractSerializer`, or `Analyzer` interfaces. Review Comment: Minor: `OptionSpace` is the final registry class behind `registerOptions()`, not something a plugin implements; `OptionSpace.register` requires a subclass of `OptionHolder`, as this page's `RocksDBOptions extends OptionHolder` example shows. Name `OptionHolder` here and in the CN step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
