imbajin commented on code in PR #411:
URL: https://github.com/apache/hugegraph-ai/pull/411#discussion_r4510189253
##########
hugegraph-llm/src/hugegraph_llm/demo/rag_demo/rag_block.py:
##########
@@ -96,15 +107,23 @@ def rag_answer(
topk_return_results=topk_return_results,
vector_dis_threshold=vector_dis_threshold,
topk_per_keyword=topk_per_keyword,
+ # Graph-only and graph+vector flows return their full state when
this
+ # is set, which is where the trace fields live.
+ is_graph_rag_recall=include_trace,
Review Comment:
⚠️ When `include_trace` is true, this also enables recall-only mode in
`RAGGraphOnlyFlow`: `GraphRecallCondition.choose()` selects the empty region
instead of `AnswerSynthesizeNode`, so a normal graph-only `/rag` request
returns an empty answer. Please use a separate flag for returning trace state
and add a test that exercises the real graph-only flow with tracing enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]