bitflicker64 commented on code in PR #411:
URL: https://github.com/apache/hugegraph-ai/pull/411#discussion_r4510944891


##########
hugegraph-llm/src/hugegraph_llm/flows/rag_flow_graph_vector.py:
##########
@@ -121,6 +123,10 @@ def post_deal(self, pipeline=None, **kwargs):
             return {"error": "No pipeline provided"}
         res = pipeline.getGParamWithNoEmpty("wkflow_state").to_json()
         log.info("RAGGraphVectorFlow post processing success")
+        if res.get("is_graph_rag_recall", False):

Review Comment:
   Important: `prepare` sets `is_graph_rag_recall` on `prepared_input` but 
leaves it out of `data_json`, so `WkFlowState.is_graph_rag_recall` stays 
`None`, this branch never runs, and `graph_vector_answer=true` with 
`include_trace=true` still returns `"trace": {}`. Add `"is_graph_rag_recall": 
is_graph_rag_recall` to `prepared_input.data_json`, as 
`RAGGraphOnlyFlow.prepare` does. 
`test_graph_vector_post_deal_returns_trace_when_requested` misses this because 
it injects the flag into the fake state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to