lplalbert opened a new pull request, #415:
URL: https://github.com/apache/hugegraph-ai/pull/415

   Refs #107 (Tiny Task: fix TODO/FIXME in LLM code)
   
   ## What
   The TODO on `InfoExtract.valid()` asked to make `max_length` configurable in 
settings
   instead of a hard-coded 256. Extracted element ids over the limit are 
dropped before graph
   write, and the limit is a deployment/storage constraint, so it belongs with 
the other
   HugeGraph settings.
   
   ## Changes
   - `HugeGraphConfig.max_element_id_length: int = 256` (compared as UTF-8 
bytes — same
     semantics as before).
   - `InfoExtract.__init__(..., max_length: Optional[int] = None)` resolves the 
configured
     limit; `valid()` falls back to it while keeping an explicit override. 
Behavior at default
     settings is unchanged (limit 256).
   - Contract tests in `test_info_extract.py`: settings default, explicit 
override, and
     `_filter_long_id` filtering.
   
   ## Validation (actually run; offline only)
   - red→green (stash-demonstrated): 3 new tests fail without the wiring → 5 
passed after
     (whole file, including the 2 pre-existing tests)
   - `SKIP_EXTERNAL_SERVICES=true uv run pytest src/tests/operators/llm_op/` → 
77 passed,
     3 subtests passed
   - `ruff format --check` / `ruff check` → clean (588 files)
   - `ty check` → 271 (same as current `main`); 0 diagnostics in touched files
   - Real-provider verification: none (offline tests only)
   
   Refs #107
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to