lplalbert opened a new pull request, #414:
URL: https://github.com/apache/hugegraph-ai/pull/414
Refs #107 (Tiny Task: fix TODO/FIXME in LLM code)
## What
`VectorStoreBase` carried 6 `#TODO: finish comment` docstrings and 2
annotations that
contradict all three backends (faiss/qdrant/milvus):
- `get_all_properties() -> list[str]`, but `add(props: List[Any])` stores
arbitrary values
(faiss keeps `list[Any]`)
- `clean() -> bool`, but every backend deletes and returns nothing
## Changes
- Wrote the six placeholder docstrings from the three backends' actual
behavior.
- Annotations: `get_all_properties` → `list[Any]`, `clean` → `None`.
- Added `src/tests/indices/test_vector_store_base_contract.py` (docstrings
complete,
annotations match the implemented contract).
## Validation (actually run; offline only)
- red→green (stash-demonstrated): 3 failed on the old contract → 17 passed,
5 skipped
(whole `src/tests/indices/` suite)
- `ruff format --check` / `ruff check` → clean
- `ty check` → no diagnostics in `indices/vector_index/base.py`
(stash-compared; the
old-contract diagnostics are gone)
- Real-provider verification: none (offline tests only)
Refs #107
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]