imbajin commented on code in PR #412:
URL: https://github.com/apache/hugegraph-ai/pull/412#discussion_r4512972762
##########
hugegraph-llm/src/hugegraph_llm/nodes/index_node/vector_query_node.py:
##########
@@ -43,7 +43,12 @@ def node_init(self):
embedding = Embeddings().get_embedding()
max_items = self.wk_input.max_items if self.wk_input.max_items is
not None else 3
- self.operator = VectorIndexQuery(vector_index=vector_index,
embedding=embedding, topk=max_items)
+ self.operator = VectorIndexQuery(
+ vector_index=vector_index,
+ embedding=embedding,
+ topk=max_items,
+ vector_dis_threshold=self.wk_input.vector_dis_threshold,
Review Comment:
⚠️ When a `/rag` request omits `vector_dis_threshold`, `RAGRequest` supplies
`0.9` and the flow forwards that value here, so setting
`VECTOR_DIS_THRESHOLD=2.0` still searches chunks at `0.9`. This makes the
documented migration escape hatch ineffective for existing API clients. Please
let an omitted request threshold resolve to the configured value and add an
API-to-store regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]