bitflicker64 commented on PR #412:
URL: https://github.com/apache/hugegraph-ai/pull/412#issuecomment-6776058037

   The earlier review comments below still apply at cc6d391; this head does not 
fix them.
   
   - Important: a `/rag` request that sends `vector_dis_threshold` (for example 
`0.9`, the field's previous default) now filters chunks at that value too, so 
on squared-L2 stores a chunk at cosine 0.5 is dropped where the base kept it. 
Keep the request field scoped to keyword matching and let chunk retrieval use 
`CHUNK_DIS_THRESHOLD` (or a separate request field). 
(https://github.com/apache/hugegraph-ai/pull/412#discussion_r4516553841)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to