bitflicker64 commented on code in PR #903:
URL:
https://github.com/apache/hugegraph-toolchain/pull/903#discussion_r4556784567
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/unit/DataTypeUtilTest.java:
##########
@@ -332,6 +334,39 @@ public void testSplitFieldWithEmptySet() {
new FileSource()).isEmpty());
}
+ @Test
+ public void testSplitFieldWithNonListCollection() {
Review Comment:
Minor: this test repeats `testSplitFieldWithLinkedHashSet`,
`testSplitFieldWithHashSet`, `testSplitFieldWithImmutableSet` and the
`assertSame` in `testSplitField`, all added by #902, and the `DataTypeUtil`
change behaves the same as `master`. Reduce the PR to the `ArrayDeque` case, or
close it as superseded by #902.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]