IG-ABHINAV commented on code in PR #903:
URL: 
https://github.com/apache/hugegraph-toolchain/pull/903#discussion_r4558904762


##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/unit/DataTypeUtilTest.java:
##########
@@ -332,6 +334,39 @@ public void testSplitFieldWithEmptySet() {
                                                  new FileSource()).isEmpty());
     }
 
+    @Test
+    public void testSplitFieldWithNonListCollection() {

Review Comment:
   Reduced as requested (875877f):
   
   **Dropped**
   - The `DataTypeUtil.splitField` source change — reverted to master's #902 
implementation (verified master already handles ArrayDeque: it's a 
`Collection`, so it goes through `new ArrayList<>(...)` rather than the `List` 
cast).
   - The test method's LinkedHashSet, HashSet, ImmutableSet assertions and the 
`assertSame` List check, which duplicate #902's 
`testSplitFieldWithLinkedHashSet` / `testSplitFieldWithHashSet` / 
`testSplitFieldWithImmutableSet` / `testSplitField`.
   
   **Remaining** (diff vs master is now 1 file, +14 lines)
   - `testSplitFieldWithArrayDeque` — the one case #902 does not cover: an 
`ArrayDeque`, i.e. a `Collection` that is neither a `List` nor a `Set`, 
asserting it is copied to `[p, q]` instead of being cast to `List`.
   
   Verified locally: `mvn -pl hugegraph-loader -am test 
-Dtest=DataTypeUtilTest` on the reduced head — 19 tests, 0 failures, 0 errors 
(BUILD SUCCESS).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to