bitflicker64 commented on PR #3473: URL: https://github.com/apache/hugegraph/pull/3473#issuecomment-7012603754
The earlier review comments below still apply at 7fe3a5b; this head does not fix them. - Important: `Database` passes `null` DB options to `initOptions`, so `rocksdb.max_open_files` and the other DB-level settings are ignored and `openReadOnly` opens every SST of the database at once, failing with `Too many open files` on a Store whose configured limit keeps its own open within `ulimit -n`. Apply the configured DB options to `this.options` (for example `RocksDBSession.initOptions(config, this.options, this.options, this.familyOptions, this.familyOptions)` before forcing `setCreateIfMissing(false)`). (https://github.com/apache/hugegraph/pull/3473#discussion_r4505347804) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
