imbajin opened a new pull request, #3473:
URL: https://github.com/apache/hugegraph/pull/3473

   ## Summary
   
   Follow-up to #3399 using a separate branch based on current ASF master, so 
the existing shared branch stays untouched. Preserve the read-only GraphID 
inspection and startup/snapshot safeguards, with conflict resolutions that 
retain both sides of the Store workflow, README, and test suite.
   
   This follow-up also addresses the outstanding findings:
   
   - Accept a valid checkpoint-derived database without a `LOCK` at startup by 
creating the empty RocksDB lock file and acquiring the lock before inspection; 
the offline check remains read-only and refuses a missing lock.
   - Show the number of databases and snapshots inspected and explicitly 
distinguish zero business-data coverage, including metadata-only roots.
   - Preserve the existing trailing-comma behavior of `app.data-path` and make 
the launcher test usable with macOS Bash.
   
   This is an upgrade guard, not a GraphID conversion tool and does not by 
itself resolve #3224.
   
   ## Validation
   
   - 29 focused `LegacyGraphIdCheckerTest` and `GraphIdCheckCommandTest` tests 
passed, including real RocksDB checkpoint creation, legacy-data refusal, the 
existing native lock holder, zero-coverage reporting and path behavior. Ran on 
JDK 21 targeting Java 17 with the JDK version enforcer disabled; a native Java 
17 run remains pending.
   - The Store checker launcher fixture passed for RocksDB and Topling runtime 
selection.
   - Independent follow-up review found no remaining blocking issues in the 
lock and coverage changes.
   
   No real multi-node upgrade or simultaneous creation of the missing `LOCK` by 
two processes was tested. Representative large-Store startup measurements 
remain open. The earlier #3399 Server memory CI failure was Maven Central HTTP 
502 during dependency resolution; this PR triggers new CI against the updated 
base.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to