xabriel commented on issue #82: Make expression binding support a case sensitivity flag URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-456595316 > What do you think about adding versions of these methods that don't have the flag and default to case sensitive? I do think that that users of `Binder#bind` should be forced to make a choice, otherwise iceberg will evolve, get new committers, and some future PR will use default behavior from `Binder#bind(StructType struct, Expression expr)`, thus inadvertently not honoring the new configuration flag that would come in a follow up PR to this one. > At least for tests, a package-private version that defaults to case sensitive would cut down on a lot of code changes. A package-private version its ok with me if you think it will make this PR easier to follow. No problem. So to summarize: 1) We will have `Binder#bind(StructType struct, Expression expr)` as package-private, thus existing tests will change minimally. 2) `Binder#bind(StructType struct, Expression expr, boolean caseSensitive)` to be used by all non-test callers. Agreed?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
