rdblue commented on a change in pull request #82: Make expression binding
support a case sensitivity flag
URL: https://github.com/apache/incubator-iceberg/pull/82#discussion_r250014071
##########
File path: api/src/main/java/com/netflix/iceberg/expressions/Evaluator.java
##########
@@ -44,7 +44,7 @@ private EvalVisitor visitor() {
}
public Evaluator(Types.StructType struct, Expression unbound) {
- this.expr = Binder.bind(struct, unbound);
Review comment:
I think some of these Evaluators will also need case sensitivity options. It
doesn't do much good to support it in expression binding if it isn't also
exposed when working with expressions in other ways. Can you also open a
follow-up issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
