fbocse commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r253920921
##########
File path:
api/src/main/java/com/netflix/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -53,12 +54,20 @@ private MetricsEvalVisitor visitor() {
return visitors.get();
}
- public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
+ InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
this.schema = schema;
this.struct = schema.asStruct();
+ this.caseSensitive = true;
Review comment:
Same as the previous comment about constructor overloading we could probably
have this constructor rewritten as `this(schema, unbound, true)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
