fbocse commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r253931335
##########
File path:
api/src/main/java/com/netflix/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -53,12 +54,20 @@ private MetricsEvalVisitor visitor() {
return visitors.get();
}
- public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
+ InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
Review comment:
I see you've also changed the access modifier for this particular
constructor, now package-private, guessing you're planning to retire this
constructor since it's no longer public? It may still be accessible by
subclasses of `InclusiveMetricsEvaluator` only within the same package though,
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
