Parth-Brahmbhatt commented on a change in pull request #87: Add LocationProvider to determine data file locations. URL: https://github.com/apache/incubator-iceberg/pull/87#discussion_r254392311
########## File path: core/src/main/java/com/netflix/iceberg/LocationProviders.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package com.netflix.iceberg; + +import com.google.common.base.Preconditions; +import com.netflix.iceberg.io.LocationProvider; +import com.netflix.iceberg.transforms.Transform; +import com.netflix.iceberg.transforms.Transforms; +import com.netflix.iceberg.types.Types; +import com.netflix.iceberg.util.PropertyUtil; +import org.apache.hadoop.fs.Path; +import java.util.Map; + +import static com.netflix.iceberg.TableProperties.OBJECT_STORE_PATH; + +public class LocationProviders { + + public static LocationProvider locationsFor(String location, Map<String, String> properties) { + if (PropertyUtil.propertyAsBoolean(properties, + TableProperties.OBJECT_STORE_ENABLED, + TableProperties.OBJECT_STORE_ENABLED_DEFAULT)) { + return new ObjectStoreLocationProvider(location, properties); + } else { + return new DefaultLocationProvider(location, properties); + } + } + + static class DefaultLocationProvider implements LocationProvider { + private final String dataLocation; + + DefaultLocationProvider(String tableLocation, Map<String, String> properties) { + this.dataLocation = stripTrailingSlash(properties.getOrDefault( + TableProperties.WRITE_NEW_DATA_LOCATION, + String.format("%s/data", tableLocation))); + } + + @Override + public String newDataLocation(PartitionSpec spec, StructLike partitionData, String filename) { + return String.format("%s/%s/%s", dataLocation, spec.partitionToPath(partitionData), filename); + } + + @Override + public String newDataLocation(String filename) { + return String.format("%s/%s", dataLocation, filename); + } + } + + static class ObjectStoreLocationProvider implements LocationProvider { + private static final Transform<String, Integer> HASH_FUNC = Transforms + .bucket(Types.StringType.get(), Integer.MAX_VALUE); + + private final String storageLocation; + private final String context; + + ObjectStoreLocationProvider(String tableLocation, Map<String, String> properties) { + this.storageLocation = stripTrailingSlash(properties.get(OBJECT_STORE_PATH)); + this.context = pathContext(tableLocation); + } + + @Override + public String newDataLocation(PartitionSpec spec, StructLike partitionData, String filename) { + return newDataLocation(String.format("%s/%s", spec.partitionToPath(partitionData), filename)); + } + + @Override + public String newDataLocation(String filename) { + int hash = HASH_FUNC.apply(filename); + return String.format("%s/%08x/%s/%s", storageLocation, hash, context, filename); + } + + private static String pathContext(String tableLocation) { + Path dataPath = new Path(tableLocation); + Path parent = dataPath.getParent(); + String resolvedContext; + if (parent != null) { + // remove the data folder + resolvedContext = String.format("%s/%s", parent.getName(), dataPath.getName()); + } else { + resolvedContext = dataPath.getName(); + } + + Preconditions.checkState( + !resolvedContext.endsWith("/"), + "Path context must not end with a slash."); + + return resolvedContext; + } + } + + private static String stripTrailingSlash(String path) { Review comment: could be replaced by []https://commons.apache.org/proper/commons-lang/apidocs/src-html/org/apache/commons/lang3/StringUtils.html#line.4978 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
