Parth-Brahmbhatt commented on a change in pull request #87: Add LocationProvider to determine data file locations. URL: https://github.com/apache/incubator-iceberg/pull/87#discussion_r254400169
########## File path: api/src/main/java/com/netflix/iceberg/io/LocationProvider.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package com.netflix.iceberg.io; + +import com.netflix.iceberg.PartitionSpec; +import com.netflix.iceberg.StructLike; +import java.io.Serializable; + +/** + * Interface for providing data file locations to write tasks. + * <p> + * Implementations must be {@link Serializable} because instances will be serialized to tasks. + */ +public interface LocationProvider extends Serializable { Review comment: Any reason the provider always expects a filename? Can we have a method that just takes the tablename and properties as input and returns the top level path as well and metadata location as well? Essentially we should be able to replace `metadataFileLocation` method from `BaseMetastoreTableOperations` and all the path related constants can be moved to this class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
