mccheah commented on a change in pull request #107: Integrate encryption into
datasource
URL: https://github.com/apache/incubator-iceberg/pull/107#discussion_r258310495
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/source/Reader.java
##########
@@ -273,14 +282,23 @@ private Schema lazyExpectedSchema() {
private Iterator<InternalRow> currentIterator = null;
private Closeable currentCloseable = null;
private InternalRow current = null;
+ private Iterator<InputFile> inputFiles = null;
Review comment:
Maintaining two iterators separately leaves the risk of advancing one
iterator and forgetting to advance the other iterator upon future modifications
of this code. I wonder if we can build this in such a manner such that we can
use a single iterator. For example we can make a struct containing both the
`FileScanTask` and the `InputFile` associated with that task (that may have
been decrypted), then make an iterator of that struct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
