mccheah commented on a change in pull request #107: Integrate encryption into
datasource
URL: https://github.com/apache/incubator-iceberg/pull/107#discussion_r258702900
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/source/Reader.java
##########
@@ -273,14 +282,23 @@ private Schema lazyExpectedSchema() {
private Iterator<InternalRow> currentIterator = null;
private Closeable currentCloseable = null;
private InternalRow current = null;
+ private Iterator<InputFile> inputFiles = null;
Review comment:
We talked offline and decided to build a `Map<String, InputFile>` to map the
paths to the input file instances (decrypted) that create the streams against
that path. When we reach a `FileScanTask` we look up this map to find the
`InputFile` that creates the associated stream. This assumes the invariant that
`fileIo.newInputFile` and `encryptionManager#decrypt` will return paths that
are consistent with their input parameters. We can check for this via
`Preconditions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
