rdsr commented on a change in pull request #108: Use the current schema in all
partition specs in scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/108#discussion_r261429495
##########
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##########
@@ -176,12 +187,15 @@ public InclusiveManifestEvaluator load(Integer specId) {
matchingManifests,
manifest -> {
ManifestReader reader =
ManifestReader.read(ops.io().newInputFile(manifest.path()));
+ PartitionSpec spec =
ops.current().spec(manifest.partitionSpecId());
toClose.add(reader);
- String schemaString = SchemaParser.toJson(reader.spec().schema());
- String specString = PartitionSpecParser.toJson(reader.spec());
- ResidualEvaluator residuals = new ResidualEvaluator(reader.spec(),
rowFilter);
+ String schemaString = SchemaParser.toJson(spec.schema());
Review comment:
Not related to this change, but it seems we are converting the PartitionSpec
to json and passing it to `BaseFileScanTask` and then, in BaseFileScanTask,
reconverting it base to PartitionSpec. Any thoughts on why that is done? Maybe
it is worth while to simply pass the PartitionSpec object directly to
`BaseFileScanTask` without first converting to json string. `BaseFileScanTask`
does not seem to be called from anywhere else
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
