rdsr commented on a change in pull request #108: Use the current schema in all
partition specs in scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/108#discussion_r261654824
##########
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##########
@@ -176,12 +187,15 @@ public InclusiveManifestEvaluator load(Integer specId) {
matchingManifests,
manifest -> {
ManifestReader reader =
ManifestReader.read(ops.io().newInputFile(manifest.path()));
+ PartitionSpec spec =
ops.current().spec(manifest.partitionSpecId());
toClose.add(reader);
- String schemaString = SchemaParser.toJson(reader.spec().schema());
- String specString = PartitionSpecParser.toJson(reader.spec());
- ResidualEvaluator residuals = new ResidualEvaluator(reader.spec(),
rowFilter);
+ String schemaString = SchemaParser.toJson(spec.schema());
Review comment:
`com.netflix.iceberg.spark.source.Reader.ReadTask` also shows a similar
pattern of usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
