rdblue commented on issue #117: Sorts bin packing by weights in descending order URL: https://github.com/apache/incubator-iceberg/pull/117#issuecomment-469921177 Thanks for working on this, @rominparekh! In addition to the comments I made, I think that releasing the largest bin first should be an option passed when creating the iterator, not a hard-coded assumption. That is how the look-back and target size parameters work and I think it would be better to keep this utility general.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
