rdblue commented on a change in pull request #117: Sorts bin packing by weights
in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r262751947
##########
File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
##########
@@ -144,6 +148,10 @@ public void add(T item, long weight) {
this.binWeight += weight;
items.add(item);
}
+
+ public long getWeight() {
Review comment:
The convention used in Iceberg is to drop the `get` from getter method names
so that they look normal when called from other languages, like Scala, that
don't have this verbose name convention. So this should just be `weight`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
