xabriel commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r263639709
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/SparkExpressions.java
##########
@@ -334,10 +336,19 @@ private static long dayToTimestampMicros(int
daysFromEpoch) {
}
}
- public static Expression convert(com.netflix.iceberg.expressions.Expression
filter,
- Schema schema) {
- return visit(Binder.bind(schema.asStruct(), filter, true), new
ExpressionToSpark(schema));
- }
+// FIXME: Let's consider removing this method as no-one is using it.
Review comment:
Right, I took care of this separately via #94.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
