xabriel commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r263640227
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/source/Reader.java
##########
@@ -218,30 +223,38 @@ public Statistics estimateStatistics() {
@Override
public String toString() {
return String.format(
- "IcebergScan(table=%s, type=%s, filters=%s)",
- table, lazySchema().asStruct(), filterExpressions);
+ "IcebergScan(table=%s, type=%s, filters=%s, caseSensitive=%s)",
+ table, lazySchema().asStruct(), filterExpressions, caseSensitive);
}
private static class ReadTask implements InputPartition<InternalRow>,
Serializable {
private final CombinedScanTask task;
private final String tableSchemaString;
private final String expectedSchemaString;
private final FileIO fileIo;
+ private final boolean caseSensitive;
private transient Schema tableSchema = null;
private transient Schema expectedSchema = null;
private ReadTask(
- CombinedScanTask task, String tableSchemaString, String
expectedSchemaString, FileIO fileIo) {
+ CombinedScanTask task,
+ String tableSchemaString,
+ String expectedSchemaString,
+ FileIO fileIo,
+ boolean caseSensitive) {
+
this.task = task;
this.tableSchemaString = tableSchemaString;
this.expectedSchemaString = expectedSchemaString;
this.fileIo = fileIo;
+ this.caseSensitive = caseSensitive;
+
Review comment:
Ack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
