rdblue commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r263836991
##########
File path:
api/src/main/java/com/netflix/iceberg/expressions/InclusiveManifestEvaluator.java
##########
@@ -53,8 +53,16 @@ private ManifestEvalVisitor visitor() {
}
public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter) {
+ this(spec, rowFilter, true);
+ }
+
+ public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter,
boolean caseSensitive) {
this.struct = spec.partitionType();
- this.expr = Binder.bind(struct,
rewriteNot(Projections.inclusive(spec).project(rowFilter)), true);
+ this.expr = Binder.bind(
+ struct,
+ rewriteNot(Projections.inclusive(spec,
caseSensitive).project(rowFilter)),
+ caseSensitive
+ );
Review comment:
I wasn't aware that some use 4. It should definitely be 2 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
