rdblue commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r266684633
##########
File path: core/src/main/java/com/netflix/iceberg/ManifestReader.java
##########
@@ -62,7 +62,18 @@
* @return a manifest reader
*/
public static ManifestReader read(InputFile file) {
- return new ManifestReader(file);
+ return new ManifestReader(file, true);
+ }
+
+ /**
+ * Returns a new {@link ManifestReader} for an {@link InputFile}.
+ *
+ * @param file an InputFile
+ * @param caseSensitive whether column name matching should have case
sensitivity
+ * @return a manifest reader
+ */
+ public static ManifestReader read(InputFile file, boolean caseSensitive) {
Review comment:
This is no longer needed because the reader has a `caseSensitive` refinement
method, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
