rdblue commented on issue #143: Applies the Baseline plugin for iceberg-api only. URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-475756415 > I've always found in my coding that 100 characters is far too short, even for Scala I've not had a problem with 100. I'm fine with either one as long as we enforce something. 120 is probably a better choice because there are cases where merges and refactors have accidentally created longer lines. I think we will have fewer changes to standardize if we use 120. > Checkstyle doesn't have a built-in rule for this, so we'd have to write one ourselves. Sounds a bit involved. My vote is to set some reasonable guidelines and not worry about it. Here's what I would do for this project: 1. If all arguments etc. fit on one line, leave it that way 2. If not, start a new line for arguments at 2 indents / 4 spaces from the start of the method definition (e.g. `public`) 3. When the argument line is full, start a new one at 2 indents / 4 spaces That would look like this: ```java public void shortMethodArgs(int foo) throws IOException { } ``` ```java public void longMethodArgs( Map<String, String> properties1, Map<String, String> properties2, Map<String, String> properties3) throws IOException, ClassNotFoundException { } ``` I don't really care for the Spark style that puts one arg on every line. It wastes a lot of vertical space.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
