rdblue commented on issue #143: Applies the Baseline plugin for iceberg-api only. URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476340278 Overall, the commit looks good to me. Everyone else okay with it? Should we also have a `STYLE.md` file somewhere that documents what we decide? If method parameter style isn't enforced, then we should write it down. It would also help to have things like the line limit and import settings documented so that people can configure their editors (or is that automatic using the `idea` task?). We don't have to add it in this PR though, if you'd like to close this out and get it in.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
