rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271094529
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -454,15 +459,32 @@ private static UnsafeProjection projection(Schema
finalSchema, Schema readSchema
}
private CloseableIterable<InternalRow> newParquetIterable(InputFile
location,
- FileScanTask task,
- Schema readSchema)
{
+ FileScanTask
task,
+ Schema
readSchema) {
return Parquet.read(location)
.project(readSchema)
.split(task.start(), task.length())
.createReaderFunc(fileSchema ->
SparkParquetReaders.buildReader(readSchema, fileSchema))
.filter(task.residual())
.build();
}
+
+ private CloseableIterable<InternalRow> newOrcIterable(InputFile location,
Review comment:
I think this class should be defined with the reader, not here in the Spark
reader. The ORC support should provide a CloseableIterable, not just an
iterator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
