rdblue commented on a change in pull request #139: ORC support integration for Spark 2.4.0 URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271094659
########## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ########## @@ -24,6 +24,35 @@ import com.google.common.collect.Iterables; import com.google.common.collect.Lists; import com.google.common.collect.Sets; +import org.apache.iceberg.AppendFiles; Review comment: Why were all these imports added? Are they used? The rest of the changes are small. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
