rdblue commented on a change in pull request #123: Add support for struct field
based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#discussion_r271458272
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
##########
@@ -130,6 +131,7 @@ public Expression bind(Types.StructType struct, boolean
caseSensitive) {
// break;
}
}
- return new BoundPredicate<>(op(), new BoundReference<>(struct,
field.fieldId()), lit);
+ return new BoundPredicate<>(op(), new BoundReference<>(schema,
field.fieldId()), lit);
}
+
Review comment:
Nit: non-functional change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
