rdblue commented on a change in pull request #123: Add support for struct field
based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#discussion_r271458387
##########
File path: api/src/test/java/org/apache/iceberg/expressions/TestEvaluatior.java
##########
@@ -47,14 +47,38 @@
private static final StructType STRUCT = StructType.of(
required(13, "x", Types.IntegerType.get()),
required(14, "y", Types.IntegerType.get()),
- optional(15, "z", Types.IntegerType.get())
+ optional(15, "z", Types.IntegerType.get()),
+ optional(16, "s1", Types.StructType.of(
+ Types.NestedField.required(17, "s2", Types.StructType.of(
Review comment:
Nit: indentation is incorrect. Continuing indents should be 4 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
