rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r274055211
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreTables.java
##########
@@ -102,12 +100,12 @@ public Transaction beginReplace(Schema schema,
PartitionSpec spec, Map<String, S
return BaseTransaction.replaceTableTransaction(ops, metadata);
} else {
String location = defaultWarehouseLocation(conf, database, table);
- metadata = newTableMetadata(ops, schema, spec, location, properties);
+ metadata = TableMetadata.newTableMetadata(ops, schema, spec, location,
properties);
return BaseTransaction.createTableTransaction(ops, metadata);
}
}
- protected String defaultWarehouseLocation(Configuration conf,
+ protected static String defaultWarehouseLocation(Configuration conf,
Review comment:
This is purposely not static so that implementations can override it. Our
metastore tracks base locations for databases and our implementation uses those
base locations to create new table paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
