rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r274056098
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -208,15 +205,14 @@ public InclusiveManifestEvaluator load(Integer specId) {
int lookback = ops.current().propertyAsInt(
TableProperties.SPLIT_LOOKBACK,
TableProperties.SPLIT_LOOKBACK_DEFAULT);
long openFileCost = ops.current().propertyAsLong(
- TableProperties.SPLIT_OPEN_FILE_COST,
TableProperties.SPLIT_OPEN_FILE_COST_DEFAULT);
+ TableProperties.SPLIT_OPEN_FILE_COST,
TableProperties.SPLIT_OPEN_FILE_COST_DEFAULT);
Function<FileScanTask, Long> weightFunc = file -> Math.max(file.length(),
openFileCost);
CloseableIterable<FileScanTask> splitFiles = splitFiles(splitSize);
- return CloseableIterable.transform(
- CloseableIterable.combine(
- new BinPacking.PackingIterable<>(splitFiles, splitSize, lookback,
weightFunc, true),
- splitFiles),
+ return CloseableIterable.transform(CloseableIterable.combine(
Review comment:
Was this change required? I liked that it was clear that all 3 lines were
not passed to the same function. (Minor)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
