rdblue commented on a change in pull request #166: Update Hive Metastore tables
for Spark
URL: https://github.com/apache/incubator-iceberg/pull/166#discussion_r277182035
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveTables.java
##########
@@ -70,12 +71,17 @@ public Table load(String tableIdentifier) {
@Override
public BaseMetastoreTableOperations newTableOps(Configuration conf, String
database, String table) {
- return new HiveTableOperations(conf, getClient(), database, table);
+ return new HiveTableOperations(conf, clients, database, table);
+ }
+
+ @Override
+ public void close() throws IOException {
+ clients.close();
}
- private ThriftHiveMetastore.Client getClient() {
- final URI metastoreUri = URI.create(MetastoreConf.getAsString(conf,
THRIFT_URIS));
- final int socketTimeOut = (int) MetastoreConf.getTimeVar(conf,
CLIENT_SOCKET_TIMEOUT, TimeUnit.MILLISECONDS);
+ private ThriftHiveMetastore.Client newClient() {
Review comment:
TODO: this is no longer used and can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
