rdblue commented on a change in pull request #166: Update Hive Metastore tables
for Spark
URL: https://github.com/apache/incubator-iceberg/pull/166#discussion_r277904246
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -231,8 +242,11 @@ private long acquireLock() throws UnknownHostException,
TException {
private void unlock(Optional<Long> lockId) {
if (lockId.isPresent()) {
try {
- metaStoreClient.unlock(new UnlockRequest(lockId.get()));
- } catch (TException e) {
+ metaClients.run(client -> {
+ client.unlock(lockId.get());
+ return null;
+ });
+ } catch (Exception e) {
Review comment:
I was wrong. This needs to be Exception to include the TException thrown if
unlock fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
