fbocse commented on a change in pull request #203: Support multiple partitions
derived from the same field
URL: https://github.com/apache/incubator-iceberg/pull/203#discussion_r290763183
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -91,7 +94,7 @@ public int specId() {
* @param fieldId a field id from the source schema
* @return the {@link PartitionField field} that partitions the given source
field
*/
- public PartitionField getFieldBySourceId(int fieldId) {
+ public List<PartitionField> getFieldsBySourceId(int fieldId) {
Review comment:
👍 I think this was actually the main issue - that this code assumes that
there can be only one Partition field per field id, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
