fbocse commented on a change in pull request #203: Support multiple partitions
derived from the same field
URL: https://github.com/apache/incubator-iceberg/pull/203#discussion_r292430845
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -312,6 +315,13 @@ private void checkAndAddPartitionName(String name) {
partitionNames.add(name);
}
+ private void checkForRedundantPartitions(PartitionField field) {
+ PartitionField timeField = timeFields.get(field.sourceId());
+ Preconditions.checkArgument(timeField == null,
Review comment:
This change could use a new unit test too, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
