rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r296332338
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORC.java
##########
@@ -40,6 +40,7 @@
public class ORC {
private static final String VECTOR_ROW_BATCH_SIZE =
"iceberg.orc.vectorbatch.size";
+ static final String COLUMN_NUMBERS_ATTRIBUTE = "iceberg.column.ids";
Review comment:
This name seems strange now that there is additional information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]