rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r296333135
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ColumnMap.java
##########
@@ -33,11 +35,48 @@
* Keep the API limited to Map rather than a concrete type so that we can
* change it later.
*/
-public class ColumnIdMap implements Map<TypeDescription, Integer> {
+public final class ColumnMap implements Map<TypeDescription,
ColumnMap.IcebergColumn> {
Review comment:
Extending map seems to require a lot of extra boilerplate code that
delegates to the internal map.
I think it would be cleaner to make serialize and inverse static methods
that accept any `Map<TypeDescription, IcebergColumn>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
