rdblue commented on a change in pull request #220: Support parsing of special
characters in TypeToSchema visitor
URL: https://github.com/apache/incubator-iceberg/pull/220#discussion_r296340533
##########
File path: core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java
##########
@@ -214,4 +220,46 @@ public Schema primitive(Type.PrimitiveType primitive) {
return primitiveSchema;
}
+
+ private static String sanitize(String name) {
+ int length = name.length();
+ StringBuilder sb = new StringBuilder(name.length());
+ char first = name.charAt(0);
+ if (!(Character.isLetter(first) || first == '_')) {
+ sb.append(sanitize(first));
+ } else {
+ sb.append(first);
+ }
+ for (int i = 1; i < length; i++) {
+ char character = name.charAt(i);
+ if (!(Character.isLetterOrDigit(character) || character == '_')) {
+ sb.append(sanitize(character));
+ } else {
Review comment:
What about an additional `else if` here that checks for numbers? That way,
the `9x` test case could be `_9x` instead of `_x39x`. No need to use the hex
encoding if it is a valid character.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
