rdblue commented on a change in pull request #220: Support parsing of special
characters in TypeToSchema visitor
URL: https://github.com/apache/incubator-iceberg/pull/220#discussion_r296340768
##########
File path: core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java
##########
@@ -214,4 +220,46 @@ public Schema primitive(Type.PrimitiveType primitive) {
return primitiveSchema;
}
+
+ private static String sanitize(String name) {
+ int length = name.length();
+ StringBuilder sb = new StringBuilder(name.length());
+ char first = name.charAt(0);
+ if (!(Character.isLetter(first) || first == '_')) {
+ sb.append(sanitize(first));
+ } else {
+ sb.append(first);
+ }
+ for (int i = 1; i < length; i++) {
+ char character = name.charAt(i);
+ if (!(Character.isLetterOrDigit(character) || character == '_')) {
+ sb.append(sanitize(character));
+ } else {
+ sb.append(character);
+ }
+ }
+ return sb.toString();
+ }
+
+ private static String sanitize(char character) {
+ return "_x" + Integer.toHexString(character).toUpperCase();
+ }
+
+ private static boolean validAvroName(String name) {
+ int length = name.length();
+ if (length == 0) {
+ throw new IllegalArgumentException("Empty name " + name);
+ }
+ char first = name.charAt(0);
+ if (!(Character.isLetter(first) || first == '_')) {
+ return false;
+ }
+ for (int i = 1; i < length; i++) {
Review comment:
Nit: For readability, I prefer to have an empty line between control flow
statements like these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
