vrozov commented on issue #271: Remove iceberg-presto-runtime that is no longer used. URL: https://github.com/apache/incubator-iceberg/pull/271#issuecomment-511137104 @rdblue Presto does not use iceberg libraries as Presto still does not support iceberg. There is an open PR to add such support and, I guess, the question is whether the PR uses `iceberg-presto-runtime` or `iceberg-api`, `iceberg-core` and other iceberg libraries directly. Indeed, the PR does not use `iceberg-presto-runtime` and my educated guess (that is based on adding iceberg support to presto on a private fork where I did not use `iceberg-presto-runtime` either) is that this was done due to a wrong shading in `iceberg-presto-runtime` (there is a large number of classes that are included into `iceberg-presto-runtime` without being relocated, causing conflicts with presto own dependencies). I still don't see anything in the PR that would solve `HiveMetaStoreClient` backward compatibility issue (note that there may be more incompatibilities in hive, just that it breaks on the very first call to hive), but I may be missing something. Possibly @electrum can clarify how hive version conflict is resolved in the PR. Yes, while it is possible to resolve all such conflicts one by one after they are discovered (and likely they won't be discovered till it blows up during run-time) or it can be solved all in once by shading and creating uber run-time jar. Another option is to use something similar to `animal-sniffer-maven-plugin` to ensure API compatibility, but I don't know if gradle provides such ability.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
