vrozov commented on issue #271: Remove iceberg-presto-runtime that is no longer used. URL: https://github.com/apache/incubator-iceberg/pull/271#issuecomment-514324803 @electrum What classes are not referenced at runtime? Iceberg `org.apache.iceberg.hive.HiveClientPool` has compile time dependency on `org.apache.hadoop.hive.metastore.HiveMetaStoreClient` and at run-time it is provided by `io.prestosql.hive:hive-apache`. What do I miss here? > BTW, just to clarify, the Presto engine doesn’t provide anything metastore or Hive related at runtime. The Iceberg plugin (like all plugins) is loaded in an isolated class loader and has complete control over all of its dependencies and versions. It is choosing to reuse code and dependencies from the Hive plugin. >> I am aware of the Presto SPI mechanism for plugins. Problem is that it will not help as the issue is with the version conflicts within a plugin classloader, not across different plugins.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
