rdblue commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-519620975 @waterlx, the day transform reports that its return type is `IntegerType.get()`, but it should be `DateType.get()`. Both are stored as integers but the transform actually produces the internal value that represents a date: the number of days from the unix epoch. Changing the return type to date should be safe and would cause engines that support the metadata tables to format the values correctly as dates instead of as integers. @timmylicheng, the compatibility checks just need to verify that older tables that are partitioned by day can still be read. It's just a matter of writing a table with the current master, making this change and reading with the new library. We don't expect any exceptions while reading or filtering after the update.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
