rdblue commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522800271 > can you point me to any other test-case or code path, where [getResultType] is being used can be verified. There might not be one. Thanks for adding tests! > If we are returning DateType.get for Days why not for Month/Year as well The values for those aren't stored as dates. For example, 1990 is stored as 20. > Anything specific I need to test/validate if this change impacts the metadata tables? Existing tests should cover it. The change should automatically update the Spark representation as well. Just fix any test failures, if there are any.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
